Skip to content

Fix path traversal and argument injection in launcher.py - #19

Open
alfieprojectsdev wants to merge 1 commit into
mainfrom
fix/launcher-path-traversal-13362144094626353616
Open

Fix path traversal and argument injection in launcher.py#19
alfieprojectsdev wants to merge 1 commit into
mainfrom
fix/launcher-path-traversal-13362144094626353616

Conversation

@alfieprojectsdev

Copy link
Copy Markdown
Owner

This PR fixes a critical security vulnerability in field-logic/launcher.py.
The script was vulnerable to path traversal (e.g., ../) and argument injection.
The fix ensures that the resolved file path is strictly within the allowed MEDIA_DIR using os.path.abspath and os.path.commonpath.
It also validates the timestamp argument to ensure it is a valid float, preventing argument injection.
A new test file field-logic/test_launcher_security.py is added to verify the security fixes.


PR created automatically by Jules for task 13362144094626353616 started by @alfieprojectsdev

Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant