Fix path traversal and argument injection in launcher.py - #19
Fix path traversal and argument injection in launcher.py#19alfieprojectsdev wants to merge 1 commit into
Conversation
Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR fixes a critical security vulnerability in field-logic/launcher.py.
The script was vulnerable to path traversal (e.g., ../) and argument injection.
The fix ensures that the resolved file path is strictly within the allowed MEDIA_DIR using os.path.abspath and os.path.commonpath.
It also validates the timestamp argument to ensure it is a valid float, preventing argument injection.
A new test file field-logic/test_launcher_security.py is added to verify the security fixes.
PR created automatically by Jules for task 13362144094626353616 started by @alfieprojectsdev