Skip to content

Add missing CSV escaping tests for quotes and newlines - #17

Open
alfieprojectsdev wants to merge 1 commit into
mainfrom
test/flattener-csv-quotes-7448476631670269931
Open

Add missing CSV escaping tests for quotes and newlines#17
alfieprojectsdev wants to merge 1 commit into
mainfrom
test/flattener-csv-quotes-7448476631670269931

Conversation

@alfieprojectsdev

Copy link
Copy Markdown
Owner

Improved test coverage for SurveyFlattener.toCSV method by adding test cases for quotes and newlines, ensuring correct CSV escaping.


PR created automatically by Jules for task 7448476631670269931 started by @alfieprojectsdev

Added unit tests to `field-logic/src/lib/flattener.test.ts` to verify that the CSV export logic correctly handles and escapes:
- Strings containing double quotes (which should be escaped by doubling).
- Strings containing newlines (which should be wrapped in quotes).
- Strings with mixed special characters (commas, quotes, newlines).

This ensures the generated CSVs are valid according to RFC 4180.

Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant