🔒 Fix CSV Injection Vulnerability in Export - #15
Conversation
Add security escaping for leading formula characters (=, +, -, @, \t, \r) by prepending a single quote to cell values. This prevents spreadsheet software from interpreting untrusted data as executable formulas. Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
The
SurveyFlattener.toCSVmethod was vulnerable to CSV injection (also known as Formula Injection). Untrusted user input starting with characters like=,+,-, or@could be interpreted as formulas by spreadsheet applications (e.g., Excel, Google Sheets).This PR implements a fix by prepending a single quote (
') to any cell value that starts with these dangerous characters, following OWASP security recommendations.🎯 What: The vulnerability fixed is CSV Injection in the export module.
⚠️ Risk: Potential for arbitrary formula execution or data exfiltration when an exported CSV is opened in spreadsheet software.
🛡️ Solution: Prepend a single quote to cell values starting with
=,+,-,@,\t, or\r.Verified with a standalone Node.js script testing various injection payloads and edge cases (commas, quotes).
PR created automatically by Jules for task 5778969242024366590 started by @alfieprojectsdev