Refactor TranscriptViewer to use button for deep link action - #12
Refactor TranscriptViewer to use button for deep link action#12alfieprojectsdev wants to merge 1 commit into
Conversation
This change improves accessibility by replacing the anchor tag (`<a>`) used for the "Open in VLC" action with a semantic `<button>` element. The button is styled to visually match the previous implementation (icon-only, no background/border) but provides correct semantics for an action that triggers a custom protocol handler rather than standard navigation. - Replaced `<a>` with `<button type="button">` - Added styles to reset button appearance - Preserved `onClick` handler logic Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Replaced the
<a>tag with a<button>element inTranscriptViewer.tsxto improve accessibility. The button is styled to look like the original icon link. Verified the change using a temporary test page and Playwright script. Confirmed that the visual appearance is preserved and the click handler functions correctly. Removed unrelated dependency changes (dexie) and generated files from the commit.PR created automatically by Jules for task 610019012517862624 started by @alfieprojectsdev