⚡ Optimize SurveyFlattener header generation - #11
Conversation
- Cache headers in constructor to avoid redundant O(N) generation in loops. - Update `generateHeaderMap` to return a copy of cached headers for safety. - Use cached headers directly in `flattenResponse` for O(1) access. - Benchmarked improvement: ~7.6% faster for 100k sessions (2295ms -> 2120ms). Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR optimizes
SurveyFlattenerby caching the header map (node IDs) in the constructor. Previously,generateHeaderMapwas called for every session intoCSV, or headers were regenerated insideflattenResponse. This change ensures headers are computed once.Changes:
private headers: string[]toSurveyFlattener.headersin constructor.generateHeaderMapto return[...this.headers].flattenResponseto usethis.headers.Performance:
PR created automatically by Jules for task 18107368058679667194 started by @alfieprojectsdev