fix: wrong-argument when yanking on Emacs >31.0.50#375
Open
epireyn wants to merge 1 commit into
Open
Conversation
When setting `dirvish-yank-sources` to 'all, it is interpreted as a custom function since `all()` is a builtin function in Emacs 31.0.50. The workaround used here is to check whether `dirvish-yank-sources` is neither "all", "session", "buffer" before calling the function associated to the symbol.
|
Hey, as of right now the maintainer for the main branch of dirvish is seemingly inactive. In the meantime, me and latiagertrutis are working on a fork here: https://github.com/latiagertrutis/dirvish. You can open the pr there if you wish. |
Author
|
Thank you for the answer! Indeed, I noticed so myself... It seems your mate has already fixed the issue with this commit. I'll be using the fork for now then, and leave this PR open for reference and if the maintainer ever comes back. |
|
No problem, I hope you have a nice day |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting
dirvish-yank-sourcesto 'all, it is interpreted as a custom function sinceall()is a builtin function in Emacs 31.0.50. The workaround used here is to check whetherdirvish-yank-sourcesis neither "all", "session", "buffer" before calling the function associated to the symbol.My knowledge of Emacs being limited, I could not make the check dynamic (the values are hard-coded). I'll be happy to change that with some pointers.