Repository navigation
Scoping: count Windows computers only; say what's done and what isn't - #22
Merged
Merged
Conversation
Found testing v0.1.3 on a real domain: checks that apply to all computers failed partly because of computer accounts that never apply Group Policy. - Only enabled computer accounts whose operatingSystem starts with "Windows" are counted. Appliances, cluster and listener names and AZUREADSSOACC are left out, and About this scan says how many. - Coverage records the containers a setting reaches and the ones it misses (largest first), with the directory's own DN spelling. - A partly applied setting reads as progress, then gap: "Done on 40 of 50 computers: OU=Workstations…", "Not yet on 10: OU=Servers… (8), OU=Domain Controllers… (2). What that leaves open: <why it matters>". The risk sentence moves there from the top of the card, so it's said once. - When the value is right everywhere it applies, Next says to apply the same setting to the machines it doesn't reach yet. - The sample report gains a workstation-only LLMNR GPO to show this. Engine 1.6.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by testing v0.1.3 on a real domain. Five checks that apply to all computers went from pass to fail. Most of those failures were real gaps: GPOs were linked to the workstations OU, but not to servers or domain controllers. A few were noise, caused by computer accounts that never apply Group Policy.
Changes
Count only Windows computers. Only enabled computer accounts whose
operatingSystemstarts with "Windows" are counted. Accounts with no Windows OS are left out: appliances, cluster and listener names,AZUREADSSOACC. "About this scan" says how many.Record where a setting goes.
evidence.coveragenow lists the containers it reaches (reached) and the ones it misses (not_reached), largest first, spelled as the directory spells them.Partly applied reads as progress, then the gap. For example:
With partial coverage, the risk line moves from the top of the card into this block, so it's said once.
Next step. When every found value is already at the target, Next says to apply the same setting to the machines it doesn't reach yet. Before, it repeated "set it to 0".
Sample report. It gains a workstation-only LLMNR GPO, so it shows this view.
Engine 1.6.1. 1,498 tests pass, including new ones for non-Windows accounts, the reached and not-reached lists, the done/not-yet block, the risk said once, and the new Next step.