Repository navigation
Conversation
A GPO now counts for a control only where it reaches the machines the
control is about, worked out from where the domain's computers sit:
- The scan reads every enabled computer once. Domain controllers are
found by account type (SERVER_TRUST_ACCOUNT or PARTIAL_SECRETS_ACCOUNT),
so a DC moved out of the Domain Controllers OU is still a DC, and an OU
that is merely named "Domain Controllers" holds none.
- A link reaches a computer when its target is the computer's container
or an ancestor of it. Block Inheritance on any container in between
stops it unless the link is enforced. OUs with Block Inheritance and no
links of their own are now read (gPLink or gPOptions).
- Coverage is reported per finding ("covered", "total", "unit"). Where
Group Policy sets a value on only some of the machines, the rest get
the control's unset meaning: its Windows default, unknown, or not
started. So a value linked only to a test OU no longer passes as
domain-wide enforcement.
- Site links are read from the forest root's Configuration partition,
and a failure is noted rather than swallowed. A site link to another
domain's GPO is no longer credited to this domain's copy with the same
GUID.
- When computers can't be read, evaluation falls back to links alone
and the report says so under "Computers scoped".
The report shows "Applies to: N of M" on each card. The sample report
uses a small made-up fleet. Engine 1.6.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is step 2 of round two. It removes the last class of false pass the consultant found, by working out which computers each GPO reaches.
What changes
Computers. The scan reads every enabled computer once and keeps a count per container. Domain controllers are found by account type:
SERVER_TRUST_ACCOUNTfor writable DCs,PARTIAL_SECRETS_ACCOUNTfor RODCs. So a DC moved out of the Domain Controllers OU still counts, andOU=Domain Controllers,OU=Labholds none.Reach. A link reaches a computer when its target is the computer's container or an ancestor of it. Block Inheritance on any container in between stops the link unless it is enforced. OUs with Block Inheritance and no links of their own are now read, using
(|(gPLink=*)(gPOptions=*)).Coverage. Each finding now records
evidence.coverage={covered, total, unit}. When Group Policy sets a value on only some of the target machines, the rest get the control's unset meaning:So
LmCompatibilityLevel=5linked only to a lab OU is now fail, 3 of 15 computers. Before, it was pass/enforced.Sites.
rootDomainNamingContext), notCN=Configuration,<base_dn>.ponytail:comment. Mapping computers to sites is a later step.Fallback. When computers can't be read, evaluation uses links alone, as before, and the report says so under "Computers scoped".
Report.
Not in this PR
gPCMachineExtensionNames.Versions and tests
Engine 1.6.0.
1,479 tests pass. New tests: