Skip to content

Fix trust bugs found in the second review round - #17

Merged
alexlinos merged 1 commit into
mainfrom
trust-fixes
Oct 2, 2026
Merged

alexlinos merged 1 commit into
mainfrom
trust-fixes

Conversation

@alexlinos

Copy link
Copy Markdown
Owner

Step 1 of round two: fixes for things that would make a reader stop trusting the report.

Wrong or misleading text

  • DEVORE-08-NTLM-AUDIT-INDOMAIN said "No value here means NTLM is blocked", the opposite of the intended meaning. My plain-language pass introduced it. It now says no value of this setting blocks NTLM.
  • "Reported as an error" notes now say "unknown", matching the card heading.
  • Channel binding: now lists events 3074 (a token would fail) and 3075 (no token sent), with the Server 2019 and 2022 updates that added them, cited to KB4520412. 3039 is described as a bind that already failed.
  • Credential Guard caveat: now scoped to signed-in users' credentials. What servers accept is still decided by the setting.
  • SPN AES "why it matters": no longer implies AES stops Kerberoasting. It slows it; a long password or a gMSA stops it.

Verdicts

  • Print Spooler (DEVORE-08-PRINT-RPCNAMEDPIPE) is now unknown when unset, not "not applicable". The old verdict assumed RPC over TCP, which the scan can't see. missing_result now accepts unknown, with no rollout stage.
  • An unlinked unreadable GPO no longer makes a missing key unknown or an error. This finishes the reach rule from Fix false passes and misleading wording found in review #12.

Report

  • "✓ Done" only on checks with a verdict. Before, an unknown showed both steps done.
  • Step 1 text on every finding. Error findings lacked interim_effect. Step 2 text now follows the change risk, so a low-risk change no longer warns of account lockouts.
  • Unconstrained delegation: its safety caveat is labelled IN STAGES and stays open, and no empty "How to roll it out safely" heading is rendered.
  • Tiles add up to the controls evaluated (21 in the sample). A conflict counts under Fix and is named "(also under Fix)" under Check by hand.
  • New "Lockout risk right now" banner in Start here when GPOs put the domain controllers at LmCompatibilityLevel 5 while other machines are below 3. The banner names both GPOs.
  • A Microsoft deadline in the scan's month reads "this month".

Versions and tests

Engine 1.5.1, catalog 2026.10.2: two verdicts change.

1,465 tests pass. There is a regression test for each fix. Changed tests:

  • Seven tests now link their unreadable GPOs, or count the Spooler as unknown.
  • Two tile tests now expect each finding to be counted once.

- DEVORE-08-NTLM-AUDIT-INDOMAIN said "No value here means NTLM is
  blocked", the opposite of what was meant. It now says no value of this
  setting blocks NTLM.
- The Print Spooler value is unknown when unset, not not_applicable: the
  scan can't see whether RPC over TCP is in use. missing_result accepts
  "unknown", which has no rollout stage.
- An unreadable GPO that doesn't apply no longer makes a missing key
  unknown or an error.
- No "Done" ticks on a check without a verdict.
- Step 1 text shows on error findings too (interim_effect was missing
  from their expected block), and step 2 text matches the change risk:
  low-risk changes no longer threaten lockouts.
- "Reported as an error" notes say "unknown", matching the card.
- Unconstrained delegation's safety caveat is labelled IN STAGES so it
  stays open; an empty "How to roll it out safely" heading isn't rendered.
- The Results tiles add up to the controls evaluated: a conflict counts
  under Fix and is named "(also under Fix)" under Check by hand.
- Start here warns "Lockout risk right now" when domain controllers are
  at LmCompatibilityLevel 5 and other machines below 3.
- A Microsoft deadline in the scan's month reads "this month".
- Channel binding lists events 3074 and 3075 with the updates that added
  them (KB4520412); the Credential Guard caveat is scoped to signed-in
  users' credentials; the SPN AES "why" no longer implies AES stops
  Kerberoasting.

Engine 1.5.1, catalog 2026.10.2: two verdicts change.
@alexlinos
alexlinos merged commit 7a2e18d into main Oct 2, 2026
3 checks passed
@alexlinos
alexlinos deleted the trust-fixes branch October 2, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant