Repository navigation
Fix trust bugs found in the second review round - #17
Merged
Merged
Conversation
- DEVORE-08-NTLM-AUDIT-INDOMAIN said "No value here means NTLM is blocked", the opposite of what was meant. It now says no value of this setting blocks NTLM. - The Print Spooler value is unknown when unset, not not_applicable: the scan can't see whether RPC over TCP is in use. missing_result accepts "unknown", which has no rollout stage. - An unreadable GPO that doesn't apply no longer makes a missing key unknown or an error. - No "Done" ticks on a check without a verdict. - Step 1 text shows on error findings too (interim_effect was missing from their expected block), and step 2 text matches the change risk: low-risk changes no longer threaten lockouts. - "Reported as an error" notes say "unknown", matching the card. - Unconstrained delegation's safety caveat is labelled IN STAGES so it stays open; an empty "How to roll it out safely" heading isn't rendered. - The Results tiles add up to the controls evaluated: a conflict counts under Fix and is named "(also under Fix)" under Check by hand. - Start here warns "Lockout risk right now" when domain controllers are at LmCompatibilityLevel 5 and other machines below 3. - A Microsoft deadline in the scan's month reads "this month". - Channel binding lists events 3074 and 3075 with the updates that added them (KB4520412); the Credential Guard caveat is scoped to signed-in users' credentials; the SPN AES "why" no longer implies AES stops Kerberoasting. Engine 1.5.1, catalog 2026.10.2: two verdicts change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 of round two: fixes for things that would make a reader stop trusting the report.
Wrong or misleading text
DEVORE-08-NTLM-AUDIT-INDOMAINsaid "No value here means NTLM is blocked", the opposite of the intended meaning. My plain-language pass introduced it. It now says no value of this setting blocks NTLM.Verdicts
DEVORE-08-PRINT-RPCNAMEDPIPE) is now unknown when unset, not "not applicable". The old verdict assumed RPC over TCP, which the scan can't see.missing_resultnow acceptsunknown, with no rollout stage.Report
interim_effect. Step 2 text now follows the change risk, so a low-risk change no longer warns of account lockouts.IN STAGESand stays open, and no empty "How to roll it out safely" heading is rendered.LmCompatibilityLevel5 while other machines are below 3. The banner names both GPOs.Versions and tests
Engine 1.5.1, catalog 2026.10.2: two verdicts change.
1,465 tests pass. There is a regression test for each fix. Changed tests: