ci: add Windows to CI test matrix#29
Open
StartupBros wants to merge 1 commit intoalexknowshtml:mainfrom
Open
Conversation
Add windows-latest alongside ubuntu-latest to surface platform-specific regressions. The codebase has Windows-specific code paths (findClaude win32 detection, getPathSeparator, shell: true for spawn) but no CI validation on Windows. Expands the matrix from 2 to 4 jobs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bab8dcf to
b8b4062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-latestto the CI matrix alongsideubuntu-latestfindClaudewin32 detection,getPathSeparatorsemicolons,shell: truefor Windows spawn)Motivation
The codebase already has Windows-specific logic and corresponding unit tests, but CI only validates on Linux. This means Windows regressions can ship undetected.
Test plan
🤖 Generated with Claude Code