security: authenticate and bind Murmur ACKs - #104
Draft
fedoseevstanislav wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
{msgId,status}delivery ACKs with a versioned Ed25519-signedAckV1envelope;markSentcall;Why
ACK correlation previously trusted attacker-controlled JSON containing only a message id and status. Anyone able to publish to an ACK subject could mark an arbitrary pending outbox row
ackedorfailed, suppressing delivery or forcing retries without authenticating the purported consumer.This change makes the security invariant explicit: only a fresh ACK signed by a pinned intended peer and bound to the exact pending envelope may transition that outbox row, and each signed ACK is processed at most once.
Related estate finding:
fedoseevstanislav/ops#728.Impact and rollout
This is intentionally wire-breaking: legacy peers cannot produce the new ACK shape, and upgraded peers reject legacy ACKs. Do not deploy this PR to a mixed-version mesh. Follow
docs/signed-acks.mdand upgrade all Murmur peers in one maintenance window.The separate NATS TLS/per-peer ACL work in #103 remains complementary: ACLs reduce who can reach ACK subjects; this PR makes forged ACK content ineffective even after subject access.
No live deployment is included in this PR.
Validation
npm test— passed (root unit, core, notification, ACP/send boundaries, A2A, WebSocket, federation, and federation-NATS suites)npm audit --audit-level=moderate— 0 vulnerabilitiesnpm run test:integration— skipped by the repository runner because Docker is unavailable on the test Mac; coordinated real-mesh smoke testing remains a deployment gate