Harden Murmur state file handling - #101
Open
fedoseevstanislav wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
0077before state/database creation0700and atomically create/replace secret JSON as0600O_NOFOLLOWand re-check the opened descriptor0600and reject unsafe database pathsWhy
Murmur agent configs contain long-term signing/encryption private keys and NATS credentials. Existing writers inherited permissive umasks and rewrites could return configs to
0664; SQLite files containing decrypted message history were also commonly0644.Validation
npm test— complete repository suite passed0600database creationnpm run buildgit diff --checkThis is immediate file-handling containment. OS-identity separation, key/token rotation, backup handling, and plaintext-history encryption/retention remain deployment responsibilities.
Tracks fedoseevstanislav/ops#729.