No more positionals after a positional slice or map#287
Merged
Conversation
|
Hey, so does this mean even the following use case is unsupported? (Essentially args for a copy program) var args struct {
Input []string `arg:"positional"`
Output string `arg:"positional"`
}So that the desired command is I'm currently working on rbcp that already uses |
Owner
Author
|
Hey @plutonium-239 yeah that is correct... unfortunately. The case you describe does not work at present, though it would be reasonably simple to add support for it. It's actually quite amazing that it's never been requested before. I'll add it to my TODOs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, go-arg returns an error if you define more positional arguments after a positional slice or map. Such positional arguments cannot be populated by go-arg. This could break programs that define positional arguments after positional slices or maps, but for whatever reason never need them to be populated by go-arg.
#265