Skip to content

An unavailable validator still triggers the corrective retry on a run without writes #951

Open

Description

@alex-mextner

What

Found by the single-seat Opus review of #941 (work of #935), finding listed in #935 (comment). Finding 9. After the validator verdict became unavailable, response-validation.ts still goes into the corrective retry for a run that made no calendar writes, which spends another model call during an outage although no verdict exists to correct against.

Why (motivation)

A corrective retry needs a rejecting verdict; unavailable is not one.

User impact

People wait longer for an answer while the validator is down, and the bot spends model calls for nothing.

Cost of inaction

Extra calls and delay during every validator outage.

Acceptance criteria

  • Test: an unavailable verdict on a run without writes ships the answer without a corrective retry
  • Test: a rejected verdict on a run without writes still takes the corrective retry

Screenshots

(none)

Deploy

Deployed: no

Links

  • (none)

Skipped gates

  • duplicate: searched incident, alert, watcher, validator, timeout, receipt; no ticket covers this
  • screenshots: no UI change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions