Repository navigation
feat(currency): add GEL, OMR, THB, MYR, KHR and TRY (Refs #250) - #253
Merged
Merged
Conversation
Add GEL, OMR, THB, MYR, KHR and TRY to all input and reporting paths. Share Unicode aliases with expense, budget, calculator and AI guards. Keep native totals precise without changing EUR-cent storage or legacy reporting; preserve OMR baisa and two-decimal ringgit, riel and lira. Cover settings, receipts, Sheets, Mini App and live/offline conversions. Refs #250
|
🔁 PR closed. Stage bot switched back to |
Replace the test-only HTML-stripping regular expression flagged by CodeQL with Bun's HTML parser while preserving all exact currency assertions. Analyze the Mini App and its SSR tests against its own package manifest in Knip, preserving the backend entries and existing analysis settings. Refs #250
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GEL, THB, MYR and TRY had display metadata but were not consistently accepted as built-in currencies; OMR and KHR were missing. Expenses could fall back to the wrong currency, and reports reconstructed from rounded EUR cents could lose small amounts such as OMR baisa or KHR.
Changes
Validation
Verified head:
3b3e6c7b5a3caf3b8cb88169b7246c7b4fd7b0ac, based on mainc1a609cc3942586b2c7aa98085e3d7deccfb282a. Rebase preserved the feature patch and retained the new Claude/HF changes. The follow-up commit only fixes SSR text extraction and Knip package scoping.TEST_CONCURRENCY=4 bun run testpassed 6,499 tests across 258 isolated files. Native pre-push completed with exit 0.bun run buildpassed 28 React-render tests, TypeScript and Vite. Vite retains its CJS API deprecation notice and the existing 582.38 kB JavaScript chunk advisory.BalanceLine.tsx,Heatmap.tsx,widgets/index.ts,SmallMultiples.tsx,AnyDataSourceRefandWidgetTypeConfig; their source files are identical to current main. These findings are not reported as a passing check.Release
Released as
bae7c8dthrough the canonical production deployment. Required CI/security checks and Stage QA passed. The owner approved the native hatch for the requested model-review waiver; ordinary commit and push hooks were retained.Independent production verification confirmed the deployed revision, a healthy restarted bot, and public/origin Mini App assets matching the deployed files. A bounded smoke against the actual deployed currency/fuzzy modules passed 147 assertions across all six currencies and 30 aliases, precision and native totals. Only the unrelated environment initializer was isolated; config reads and network calls were zero, and no user financial records were written. Task #250 is done with all eight criteria verified and deployment recorded.
Refs #250