Skip to content

Budget UX polish nits from the setup-UX landing reviews: stale prompt buttons, button-amount cap parity #244

Open

Description

@alex-mextner

What

Three non-blocking findings from the #242 landing reviews (2026-11-06) for #123: (1) after a typed-amount apply, the budget prompt message keeps its inline buttons — pressing them later correctly answers «устарел», but the prompt message should be edited/removed on apply; (2) suggested-amount buttons have no upper-bound parity with typed amounts (parseBudgetInputAmount caps at 1e12, budget:psuggest buttons do not — inconsistent, not exploitable since amounts are generated); (3) the already_handled race path in the budget-prompt text flow (prompt finished between lookup and apply) is silent — add a debug log.

Why (motivation)

Deferred to keep the landing PR atomic; findings recorded by the machine review runs and the independent reviewer.

User impact

A user who sets a budget by typing an amount still sees dead buttons under the old prompt and can press them by accident; if two replies race, nobody can tell from the logs why the second one did nothing.

Cost of inaction

Chats keep accumulating dead prompt buttons and the race stays undiagnosable.

Acceptance criteria

  • Applying a budget via typed amount edits or deletes the original prompt message so its buttons are no longer reachable
  • Suggested button amounts pass through the same upper-bound guard as typed amounts (or the inconsistency is documented as safe)
  • The already_handled race emits a debug-level log line with the prompt id

Screenshots

(none)

Deploy

Deployed: no

Links

  • (none)

Skipped gates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions