Fixing of hanging after "exit" in process which is linked to handler …#3
Open
AntonZaets wants to merge 1 commit intoalertlogic:upstreamfrom
Open
Fixing of hanging after "exit" in process which is linked to handler …#3AntonZaets wants to merge 1 commit intoalertlogic:upstreamfrom
AntonZaets wants to merge 1 commit intoalertlogic:upstreamfrom
Conversation
…process
Problem statement:
Request handler start linked process, which is finishing with exit(Reason).
In such case the `info` function clause for error handling will never be called
and default clause will be called instead. This causes hanging of cowboy.
The typical situation is starting gen_server from request handler.
If gen_server returns {stop, Reason} after error in initialisation
then otp calls `exit(Reason)` internally.
The solution:
New `info` clause for error without stacktrace.
motobob
approved these changes
Dec 27, 2017
|
let's review other alternatives before we merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem statement:
Request handler start linked process, which is finishing with
exit(Reason).In such case the function clause for error handling will never be called and default clause will be called instead. This causes hanging of cowboy.The typical situation is starting
gen_serverfrom request handler. Ifgen_serverreturns{stop, Reason}after error in initialisation thenotpcallsexit(Reason)internally.The solution:
New
infoclause for error without stacktrace.@motobob please, take a look.