Skip to content

feat: support credit payment in store messages#278

Merged
amalcaraz merged 1 commit intomainfrom
feature/store-pay-with-credit
Feb 17, 2026
Merged

feat: support credit payment in store messages#278
amalcaraz merged 1 commit intomainfrom
feature/store-pay-with-credit

Conversation

@amalcaraz
Copy link
Contributor

Summary

  • Add support for credit payment in STORE messages
  • Update aleph-message dependency to version 1.1+ to support new payment types
  • Add optional payment parameter to create_store method with ETH hold as default

Changes

API Changes

  • AuthenticatedAlephClient.create_store(): Added optional payment parameter
    • Defaults to Payment(chain=Chain.ETH, type=PaymentType.hold, receiver=None) if not provided
    • Allows users to specify alternative payment methods (e.g., credit)

Dependencies

  • Updated aleph-message from >=1.0.5 to >=1.1 to support new payment types

Testing

  • Added test for creating instance with credit payment
  • Added test for creating store message with credit payment
  • Added test to verify default payment behavior (ETH hold)

Test Plan

  • Unit tests pass for credit payment in store messages
  • Unit tests pass for credit payment in instance messages
  • Default payment behavior verified (ETH hold when not specified)
  • Backwards compatibility maintained (existing code works without changes)

Backwards Compatibility

✅ Fully backwards compatible - the payment parameter is optional and defaults to the existing behavior (ETH hold).

@amalcaraz amalcaraz self-assigned this Feb 16, 2026
@github-actions
Copy link

Failed to retrieve llama text: POST 503:

503 Service Unavailable


No server is available to handle this request.

@amalcaraz amalcaraz merged commit 2c115f3 into main Feb 17, 2026
38 checks passed
@amalcaraz amalcaraz deleted the feature/store-pay-with-credit branch February 17, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants