Skip to content

refactor: extract document loading session - #274

Merged
alecdotdev merged 1 commit into
alecdotdev:masterfrom
PathGao:agent/extract-document-load-session
Jul 30, 2026
Merged

refactor: extract document loading session#274
alecdotdev merged 1 commit into
alecdotdev:masterfrom
PathGao:agent/extract-document-load-session

Conversation

@PathGao

@PathGao PathGao commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move document loading, tab selection, preview loading, and large-file completion guards into documentSession
  • keep rendering, viewport measurement, recent-file UI, and error presentation as MarkdownViewer callbacks
  • preserve the clean revision, dirty-state, and view-mode guard before a deferred full-file result can apply

Depends on #273 (and #272/#271). Merge after #273. This starts the document-session extraction; save, task mutation, watcher, and close flows remain separate follow-up steps.

Validation

  • npm run check
  • npm test (117 passing)
  • cargo test (18 passing)

@PathGao

PathGao commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@alecdotdev This is the first document-session PR, dependent on #273. It moves loading and the deferred large-file completion guard without changing document mutation behavior; save, task, watcher, and close ownership will follow in smaller dependent PRs.

@PathGao
PathGao force-pushed the agent/extract-document-load-session branch from 110a3c2 to f2b10b8 Compare July 30, 2026 04:00
@PathGao

PathGao commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@alecdotdev Rebased after #271 merged; its direct parent is the updated #273 branch.

@PathGao
PathGao force-pushed the agent/extract-document-load-session branch from f2b10b8 to 024e831 Compare July 30, 2026 04:54
@PathGao
PathGao force-pushed the agent/extract-document-load-session branch from 024e831 to 80118b6 Compare July 30, 2026 05:04
@alecdotdev
alecdotdev merged commit bb8dbf3 into alecdotdev:master Jul 30, 2026
5 checks passed
@PathGao
PathGao deleted the agent/extract-document-load-session branch July 30, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants