Added DEL key action for gaining 100 exp in battles#1
Open
Cyan627 wants to merge 1 commit into
Open
Conversation
aldelaro5
requested changes
Jul 12, 2020
Owner
aldelaro5
left a comment
aldelaro5
left a comment
There was a problem hiding this comment.
Other than that, the code seems good to me, however, I will need to test this and it seems I will be busy the coming week, but I should have time to properly test and review this next week. In the meantime, feel free to do the requested changes :)
| namespace SpeedrunPractice | ||
| { | ||
| [BepInPlugin("com.aldelaro5.BugFables.plugins.SpeedrunPractice", "Speedrun Practice", "2.0.1")] | ||
| [BepInPlugin("com.aldelaro5.BugFables.plugins.SpeedrunPractice", "Speedrun Practice", "2.0.2")] |
Owner
There was a problem hiding this comment.
Don't version bump as part of the commit, I will be the one to do it when I do a release to tag it.
aldelaro5
changed the title
aldelaro5
approved these changes
Jul 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello to everyone who sees this,
I added one new functionality to the Practice DLL so that it can add 100 Exploration Points to any battle by pressing the DEL key in battle (the UI bugs out slightly because they show up as small and not big exp orbs but it's functional for the time being until I learn how to fix that).
Aside from that, I changed the version numbers and added my name which I understand this isn't anything groundbreaking so I'm fine with all other changes being removed. I do plan on working on this more in the future though.
This is also my first time working with C# and really my first contribution to any open source project so I wanted to give a huge shoutout and thank you to aldelaro5 for giving me the basics and basically carrying me through this first pull request.