Repository navigation
Reject codes with a trailing newline - #59
Merged
Merged
Conversation
In PCRE, $ also matches before a final "\n", so "EUR\n", "978\n" and "NL\n" passed the format checks and then threw OutOfBoundsException. Anchor with \z so they throw DomainException like other malformed input. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 17 17
===========================================
Files 1 1
Lines 32 32
===========================================
Hits 32 32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PCRE,
$also matches just before a final\n. SogetByAlpha3("EUR\n"),getByNumeric("978\n")andgetByCountry("NL\n")passed the format check, failed the lookup, and threwOutOfBoundsException("does not contain") instead ofDomainException("Not a valid ...").This anchors all three format regexes with
\zinstead of$, adds data-provider cases for each method, and adds aFixed:line to the CHANGELOG under Unreleased.Behaviour change: such input now throws
DomainException. Both exceptions implementAlcohol\ISO4217\Exception, and neither input was ever a valid lookup. The new tests fail on the old regexes and pass with the fix, on PHP 8.5 (PHPUnit 12) and 7.4 (PHPUnit 9).The CHANGELOG will conflict with #58 (both add a line under Unreleased). I'll rebase whichever merges second.
🤖 Generated with Claude Code