Repository navigation
Reject codes with a trailing newline - #135
Merged
Merged
Conversation
In PCRE, `$` also matches before a final newline, so "NL\n" passed the alpha2 format check and surfaced as OutOfBoundsException (not found) instead of DomainException (invalid). Anchor with \z instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
=========================================
Coverage 95.69% 95.69%
Complexity 46 46
=========================================
Files 4 4
Lines 93 93
=========================================
Hits 89 89
Misses 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guardsanchored its format regexes with$, which in PCRE also matches just before a final newline. Soalpha2("NL\n"),alpha3("NLD\n")andnumeric("528\n")passed the format check and then threwOutOfBoundsException(not found) instead ofDomainException(invalid format).The patterns now end in
\z. There are new data-provider cases for each method; they fail without the fix.Name handling (the guard trims, the lookup doesn't) is unchanged here. It's covered by the 5.0 design.
🤖 Generated with Claude Code