Skip to content

Fix currency data (#130) - #133

Merged
alcohol merged 1 commit into
mainfrom
fix-currency-data-130
Nov 2, 2026
Merged

alcohol merged 1 commit into
mainfrom
fix-currency-data-130

Conversation

@alcohol

@alcohol alcohol commented Nov 2, 2026

Copy link
Copy Markdown
Owner

Fixes #130. The changes were checked against the SIX ISO 4217 List One (2026-09-17) and List Three (historic).

Country Before After
AQ Antarctica … BYR … … BYN … (BYR was withdrawn in 2016)
ZW Zimbabwe BWP, EUR, GBP, USD, ZAR + ZWG
BT Bhutan BTN BTN, INR
HT Haiti HTG HTG, USD
IO British Indian Ocean Territory GBP GBP, USD
PA Panama PAB PAB, USD
CU Cuba CUC, CUP CUP (CUC was withdrawn in 2021-06)

Also adds a Nauru → Naoero alias to ISO3166WithAliases. Since 4.5.0, name('Nauru') throws OutOfBoundsException on the plain class; the alias restores it when ISO3166WithAliases is used.

Kept on purpose: AQ's list of currencies used at research stations, and ZW's foreign currencies in everyday use. ISO 4217 assigns neither.

🤖 Generated with Claude Code

- Antarctica: BYN instead of the withdrawn BYR
- Zimbabwe: add ZWG
- Bhutan: add INR; Haiti, British Indian Ocean Territory, Panama: add USD
  (per SIX ISO 4217 List One, 2026-09-17)
- Cuba: drop CUC (withdrawn 2021-06, SIX List Three)
- ISO3166WithAliases: accept 'Nauru' for 'Naoero'

Fixes #130

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.69%. Comparing base (2a078a4) to head (c668a34).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #133   +/-   ##
=========================================
  Coverage     95.69%   95.69%           
  Complexity       46       46           
=========================================
  Files             4        4           
  Lines            93       93           
=========================================
  Hits             89       89           
  Misses            4        4           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alcohol
alcohol merged commit 0e965fc into main Nov 2, 2026
10 checks passed
@alcohol
alcohol deleted the fix-currency-data-130 branch November 2, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Currency data: AQ lists withdrawn BYR, ZW missing ZWG

2 participants