Fix node-pty spawn-helper executable permissions#23
Open
OuyangMr wants to merge 1 commit into
Open
Conversation
OuyangMr
force-pushed
the
node-pty-spawn-helper-perms
branch
4 times, most recently
from
51a2d59 to
10c1bf5
Compare
OuyangMr
force-pushed
the
node-pty-spawn-helper-perms
branch
from
10c1bf5 to
771386e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
When node-pty's darwin spawn-helper loses its executable bit, opening FanBox's embedded terminal fails with
posix_spawnp failed. This makes the terminal unusable after affected installs or dependency refreshes.Verification
npm run postinstallnpm run predistnode-pty.spawn('/bin/zsh')smoke test