Skip to content

Add methods of kron with Diagonal#40

Merged
albertomercurio merged 2 commits into
mainfrom
patch-1
Jan 31, 2026
Merged

Add methods of kron with Diagonal#40
albertomercurio merged 2 commits into
mainfrom
patch-1

Conversation

@albertomercurio

Copy link
Copy Markdown
Owner

Adding methods of kron with Diagonal matrices. It also supports Diagonal{T, <:AbstractFill{T}} thought FillArrays.jl.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Benchmark Results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: c1d46c5 Previous: 69c7e1d Ratio
Three-argument dot/Array/COO 2491930.5 ns 1038576 ns 2.40

This comment was automatically generated by workflow using github-action-benchmark.

@albertomercurio albertomercurio merged commit c161bbb into main Jan 31, 2026
15 of 19 checks passed
@codecov

codecov Bot commented Feb 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.43363% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.46%. Comparing base (22d416d) to head (c1d46c5).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/matrix_coo/matrix_coo_kernels.jl 0.00% 27 Missing ⚠️
ext/GenericSparseArraysFillArraysExt/kernels.jl 0.00% 24 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (22d416d) and HEAD (c1d46c5). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (22d416d) HEAD (c1d46c5)
10 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #40       +/-   ##
===========================================
- Coverage   87.46%   60.46%   -27.01%     
===========================================
  Files          13       16        +3     
  Lines        1237     1424      +187     
===========================================
- Hits         1082      861      -221     
- Misses        155      563      +408     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant