Repository navigation
Refactor: Centralize Endgame Mission Lookup - #313
Conversation
Extract duplicated endgame mission ID parsing logic into a pure utility `getEndgameMissionDef` in `src/utils/gamification/missionLogic.ts`. Replaces brittle inline string splitting and arrays searches previously scattered across: - `src/utils/gamification/missionLogic.ts` - `src/utils/gamification/questionLogic.ts` - `src/components/gamification/MissionList/MissionList.tsx` This adheres to DRY and makes ID resolution safer. Co-authored-by: albertoivo <1276520+albertoivo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Visit the preview URL for this PR (updated for commit 0a45926): https://pyexplorer-cd32d--pr313-refactor-centralize-flf0x17z.web.app (expires Sun, 15 Nov 2026 05:44:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 916b4905e0cdc420f3368c8eb19b2f2e90c3be61 |
Extract duplicated endgame mission ID parsing logic into a pure utility
getEndgameMissionDefinsrc/utils/gamification/missionLogic.ts. Replaces brittle inline string splitting and array searches previously scattered acrosssrc/utils/gamification/missionLogic.ts,src/utils/gamification/questionLogic.ts, andsrc/components/gamification/MissionList/MissionList.tsx. This adheres to DRY and makes ID resolution safer.PR created automatically by Jules for task 7940127247041383440 started by @albertoivo