Skip to content

Refactor: Centralize Endgame Mission Lookup - #313

Merged
albertoivo merged 1 commit into
mainfrom
refactor-centralize-endgame-missions-7940127247041383440
Nov 8, 2026
Merged

albertoivo merged 1 commit into
mainfrom
refactor-centralize-endgame-missions-7940127247041383440

Conversation

@albertoivo

Copy link
Copy Markdown
Owner

Extract duplicated endgame mission ID parsing logic into a pure utility getEndgameMissionDef in src/utils/gamification/missionLogic.ts. Replaces brittle inline string splitting and array searches previously scattered across src/utils/gamification/missionLogic.ts, src/utils/gamification/questionLogic.ts, and src/components/gamification/MissionList/MissionList.tsx. This adheres to DRY and makes ID resolution safer.


PR created automatically by Jules for task 7940127247041383440 started by @albertoivo

Extract duplicated endgame mission ID parsing logic into a pure utility
`getEndgameMissionDef` in `src/utils/gamification/missionLogic.ts`.

Replaces brittle inline string splitting and arrays searches previously
scattered across:
- `src/utils/gamification/missionLogic.ts`
- `src/utils/gamification/questionLogic.ts`
- `src/components/gamification/MissionList/MissionList.tsx`

This adheres to DRY and makes ID resolution safer.

Co-authored-by: albertoivo <1276520+albertoivo@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 0a45926):

https://pyexplorer-cd32d--pr313-refactor-centralize-flf0x17z.web.app

(expires Sun, 15 Nov 2026 05:44:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 916b4905e0cdc420f3368c8eb19b2f2e90c3be61

@albertoivo
albertoivo merged commit b56a9ef into main Nov 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant