Repository navigation
refactor(gamification): extract getEndgameMissionDef utility - #312
albertoivo wants to merge 1 commit into
Conversation
Extract duplicated endgame mission lookup and hydration logic into
a centralized, pure utility function \`getEndgameMissionDef\`. This
replaces fragile string parsing (\`.split('_')[1]\`) with robust regex
handling, preventing bugs with objective types containing underscores.
Closes code duplication issues in:
- \`src/utils/gamification/missionLogic.ts\`
- \`src/utils/gamification/questionLogic.ts\`
- \`src/components/gamification/MissionList/MissionList.tsx\`
Co-authored-by: albertoivo <1276520+albertoivo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Extract duplicated endgame mission lookup and hydration logic into a centralized, pure utility function
getEndgameMissionDef. This replaces fragile string parsing (.split('_')[1]) with robust regex handling, preventing bugs with objective types containing underscores. Closes code duplication issues across the gamification domain.PR created automatically by Jules for task 10629375988499865136 started by @albertoivo