Skip to content

Option to not sandbox the username #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dododedodonl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Option to not sandbox the username #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ftpd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,10 +439,17 @@ function createServer(host, sandbox) {
socket.emit(
"command:pass",
commandArg,
function(username) { // implementor should call this on successful password check
function(username, sandboxUsername) { // implementor should call this on successful password check
socket.write("230 Logged on\r\n");
socket.username = username;
socket.sandbox = PathModule.join(server.baseSandbox, username);

//Sandbox the username by default, but overwrite is possible (true/false)
sandboxUsername = (typeof sandboxUsername === "undefined") ? true : sandboxUsername;
if(sandboxUsername) {
socket.sandbox = PathModule.join(server.baseSandbox, username);
} else {
socket.sandbox = server.baseSandbox;
}
},
function() { // call second callback if password incorrect
socket.write("530 Invalid password\r\n");
Expand Down