Feature/heartbeat transaction

[alanmasu]

I fixed some static code analysis errors and applied the styling convention

[alanmasu]

Lines repeted each time, should we move it on the onMessage function??

[Tech-Matt]

I agree that the guard is repeated. I would move only replicaStatus == CRASHED into onMessage path. I would keep heartbeatTransaction == null heartbeat-specific, because onMessage also handles other messages.

[alanmasu]

After merging #81 will be removed completely the method, and di per se there is no error if we don't check the non-null value of the heartbeatTransaction

[Tech-Matt]

I agree that the guard is repeated. I would move only replicaStatus == CRASHED into onMessage path. I would keep heartbeatTransaction == null heartbeat-specific, because onMessage also handles other messages.

[Tech-Matt]

When the watchdog timer fires, line 262 changes the state to ELECTION_REQUESTED, but timeout still points to the timer that has already finished. Current behavior seems fine, but setting timeout = null here would make it clear that no timer is active anymore. Could we keep that line?

[alanmasu]

This is violating the Static Code Analysis, if is not strict necessary I would remove it, if you think is necessary a better solution will be to change it from Cancellable to Optional<Cancellable> and use this API.

[alanmasu]

If you find other occurences of this "error" please telll me!

[Tech-Matt]

It is actually fine, we can remove it

[Tech-Matt]

Good job, no new feedback from me. We can merge!