Add build agent trace foundation - #203
Open
alandotcom wants to merge 1 commit into
Open
Conversation
commit: |
alandotcom
force-pushed
the
agent-quality/trace-foundation
branch
from
September 3, 2026 17:27
c6ae060 to
80cc93c
Compare
alandotcom
marked this pull request as ready for review
September 3, 2026 19:26
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandotcom
force-pushed
the
agent-quality/trace-foundation
branch
from
September 3, 2026 19:32
80cc93c to
552f213
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a provider-neutral trace for build-agent turns. The private eval harness can now inspect full model-facing tool data and exact graph revisions, while production logs retain aggregate metrics and exclude workflow and tool payloads.
Review guide
Start with
packages/core/src/backend/agent/trace.tsandpackages/core/src/backend/agent/chat.tsfor the trace contract and step lifecycle. Then reviewpackages/core/src/backend/services/agent/chat.tsfor aggregate logging and capacity ownership. The RPC adapter inpackages/core/src/backend/rpc/router.tskeeps the producer fiber inside the application runtime and binds cancellation to the request signal and iterator cleanup.What changed
AgentStreamPartcontract remains unchanged.Validation
pnpm run type-checkpnpm run lintpnpm run test: 3,567 passed; 37 PostgreSQL tests skipped because no test database was configuredpnpm run buildpnpm run knippnpm run skills:validatepnpm run checkpnpm run evals: 28 of 28 model-backed runs passed on the unchanged baseline and on this branch