Move SQLite persistence to Effect SQL and Drizzle - #192
Merged
Conversation
Replace direct node:sqlite repository access with the Effect SQLite adapter and Drizzle SQL while preserving the public persistence contract and transaction semantics. Adopt exact legacy version 6 and 7 schemas into a generated migration journal, reject drift and newer journals, and validate migrations atomically.\n\nBundle the patched Drizzle Effect adapter for published consumers and add a packed-tarball smoke test to PR checks.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace production
node:sqliterepository access withdrizzle-orm/effect-sqlite-nodewhile preservingwfSqlite(), stored data, repository contracts, and transaction behavior. This moves connection lifecycle and serializedBEGIN IMMEDIATEwrites into Effect SQL and makes generated Drizzle migrations the schema source of truth.Review guide
Start with
packages/core/src/backend/persistence/sqlite/migrations.tsanddatabase.ts, then the generated schema and migration tests. The main risk surfaces are legacy database adoption, rollback under failed migrations, and the installed-package path for the patched Drizzle adapter.What changed
__wfgraph_sqlite_migrationswithout rewriting application tables. Reject older, partial, altered, tampered, or newer schemas instead of guessing.DatabaseErrortranslation and existing row contracts.@wfgraph/corein a clean directory during PR checks, then open and migrate SQLite through the published entry.Validation
pnpm install --frozen-lockfilepnpm run checkpnpm run type-checkpnpm run lintpnpm run test: 3,289 passed; 37 PostgreSQL tests skipped in the general suiteWFGRAPH_REQUIRE_POSTGRES=1 WFGRAPH_TEST_DATABASE_URL=... pnpm run test:postgres: 37 passedpnpm run buildpnpm run knippnpm run skills:validatepnpm run db:generate:sqlitepnpm run package:smoke