Skip to content

Type Resend HTTP boundary from SDK - #188

Open
alandotcom wants to merge 10 commits into
mainfrom
cursor/type-resend-wire-1801
Open

Type Resend HTTP boundary from SDK#188
alandotcom wants to merge 10 commits into
mainfrom
cursor/type-resend-wire-1801

Conversation

@alandotcom

@alandotcom alandotcom commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • derive the send request contract directly from Resend's public EmailApiOptions
  • enforce request completeness and content-mode exclusivity at sendResendEmail
  • keep the transport on JsonObject without casts or runtime branching
  • bind Effect response codecs to SDK success-response projections
  • retain the es-toolkit 1.52 upgrade and shape only optional metadata with omitBy
  • accept numeric template fallbacks while keeping the SDK out of runtime bundles
  • compile-test that template and body content cannot be combined

Testing

  • pnpm run type-check
  • pnpm run lint
  • pnpm exec vitest run packages/plugins/src/resend — 118 passed
  • pnpm run test — 3,198 passed, 35 skipped
  • pnpm run build
  • pnpm run knip
  • pnpm run skills:validate
  • pnpm run fix
  • packed @wfgraph/plugins; no runtime Resend import and no leaked Resend declaration import
  • thermo-nuclear follow-up review — approved with no remaining findings
Open in Web Open in Cursor 

Co-authored-by: Alan Cohen <alan@forwardstation.dev>
@pkg-pr-new

pkg-pr-new Bot commented Aug 31, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/@wfgraph/client@52f5fb0
pnpm add https://pkg.pr.new/@wfgraph/core@52f5fb0
pnpm add https://pkg.pr.new/@wfgraph/plugins@52f5fb0

commit: 52f5fb0

@alandotcom
alandotcom marked this pull request as ready for review August 31, 2026 22:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T01:26:47.756175Z 52f5fb0 New commits
🔒 Security Review Completed 2026-08-31T22:20:15.939452Z 0c3746c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-authored-by: Alan Cohen <alan@forwardstation.dev>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Co-authored-by: Alan Cohen <alan@forwardstation.dev>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Co-authored-by: Alan Cohen <alan@forwardstation.dev>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Co-authored-by: Alan Cohen <alan@forwardstation.dev>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Co-authored-by: Alan Cohen <alan@forwardstation.dev>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Co-authored-by: Alan Cohen <alan@forwardstation.dev>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Co-authored-by: Alan Cohen <alan@forwardstation.dev>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants