Repository navigation
perf(audio): avoid eager DSP work in idle engines - #138
Merged
alan7383 merged 3 commits intoNov 18, 2026
Merged
Conversation
ilgiova237
marked this pull request as ready for review
November 18, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the shared audio engine built and configured every effect processor during player construction, even before any PCM existed. saved FX/EQ settings also updated the DSP directly from the caller's thread.
this creates the effect graph on the decoder's first PCM block and applies pending FX, EQ and stretch settings at block boundaries. it keeps the latest pre-play settings and automix ratios, configures processors before use, and releases a graph that loses a race with engine disposal. stopping or releasing an idle engine does not create DSP resources.
this is shared code for Linux and Windows. the six new tests run in the Windows headless job and both Linux jobs. no UI, DSP equations or signal order changed.
validation:
filesystem caches were warm. all paired samples were retained, launches were gated on quiet CPU, and the endpoint required the actual main screen's draw marker and a visible window owned by that process. these timings are from Windows hardware; Linux coverage is functional CI, not a claimed Linux timing result. preparing the already-existing AOT cache for the personal installed build is separate work and its gain is not attributed to this PR.