Repository navigation
fix(windows): update the current installation and preserve shortcuts - #137
Merged
alan7383 merged 3 commits intoNov 19, 2026
Merged
Conversation
ilgiova237
marked this pull request as ready for review
November 16, 2026 06:11
Owner
|
:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the windows updater was reading
jpackage.app.path, but the launcher setsjpackage.app-path. a portable/custom installation could therefore update or relaunch another copy. the helper also relaunched the existing exe after installer failure without checking which version was actually installed.this keeps the update in the current folder, passes
INSTALLDIRon every MSI attempt, and forces file replacement withREINSTALLMODE=amusso an existing launcher config cannot keep pointing at an older jar. it snapshots matching desktop, start menu and taskbar shortcuts and restores their original bytes afterward, including custom icons and arguments.before relaunching, the helper checks the installed launcher version against the requested release and checks that its classpath files exist. failed or incomplete installs are logged instead of silently reopening the old app. reboot-required exit codes stop retries and defer relaunch until Windows restarts. helper scripts use a UTF-8 BOM for Windows PowerShell 5.1, and process cleanup is limited to the selected executable path.
Windows MSI and portable images now contain
version.txtbesideKittyTune.exe. the portable CI check compares it with the launcher's actual version.validation:
.lnkfiles, deletes a matching link to simulate installer removal, then verifies byte-for-byte restoration and that an unrelated link stays unchanged.headlessTestrun passed: 341 tests, 0 failures, 0 errors, 3 skipped. the native Widevine/CDM build tasks were excluded from this run.no live MSI upgrade was performed on the user's installation. all four GitHub checks passed, including the Windows portable build, its version-file content check and the transparent-window renderer regression. the MSI + portable task graph also passed a local dry run.