Repository navigation
fix(windows): unblock startup cache preparation - #136
Merged
alan7383 merged 4 commits intoNov 15, 2026
Merged
Conversation
ilgiova237
marked this pull request as ready for review
November 15, 2026 15:41
Owner
|
AOT cache preparation triggered two blue screens on my RX 7700 XT. Both dumps pointed to the AMD driver while Java was loading a native DLL, likely from JavaCPP’s deeply nested cache path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the existing windows startup-cache helper failed on the test image: recording exceeded its two-minute cutoff, and assembly exceeded windows' command-line limit in the long image path. locked temporary files could mask the original error.
this uses utf-8 java argument files, adds a configurable ten-minute process timeout, retains partial timeout diagnostics, and makes cleanup locks warnings. existing cache/config files are still replaced only after assembly and validation succeed. no application or ui code changes.
the fixed helper completed actual preparation and strict cache validation locally. enabling the existing aot cache on an unchanged copy of the installed 1.5.1 package produced:
cache-on was faster in all 10 matched pairs. the median saving was 4.15 seconds. these results measure enabling the existing cache with the preparation workflow fixed; they are independent of #132 and do not include its device-probe change.
two excluded warmups, ten alternating pairs, fresh processes and warm filesystem caches. both variants used the same exe, runtime, jars, renderer and synthetic guest state; http used a refused loopback proxy. the endpoint required a first-draw marker from the main screen plus a visible win32 window in the launcher's process tree, polled every 25 ms. device-probe helpers were allowed to finish between launches. all 20 measured samples are retained. the load gate paused before the last baseline; that single remaining launch was resumed with the same image and seed after verifying the artifact hashes. the earlier validation run is not included in these figures.
four process-level helper tests pass locally and in windows ci. the unchanged helper fails both the long-argument and locked-cleanup regression cases. tests also cover unicode paths, preservation on assembly failure and timeout diagnostics. actual recording took about 139 seconds on this laptop, beyond the old limit.
this is a one-time explicit preparation step using the matching jdk, not work added to every launch. the archive is about 100 mib and needs preparing again after jar updates/re-extraction; normal startup falls back automatically if it is missing or incompatible. no cold-disk, online-feed, playback or cpu-percentage claim is made. the user's installed copy was not modified.
reproduction and methodology:
experiments/windows-startup-cache/README.md.all measured samples and artifact hashes
1a6cc1e347af0c70fee55914182861daef5186b1924d8ae59116126d30d44c695215050d6fc0404e655c0f8d97d32e6fda0b2d5d7e2536c701848997ef75893ae534046be028cff2a3b6e735622905c380764acdb86a837f03c5166616918c12