fix: suppress Go's *exec.ExitError leakage into task output#130
Merged
Conversation
Previously, when a task command exited non-zero, mani appended Go's
stdlib *exec.ExitError string ('exit status N') to the output cell
(table mode) or to stderr (stream mode). This is internal Go
representation leaking through — the command's own stderr is already
captured separately, so the suffix added no information when failures
were real, and polluted the cell when commands intentionally exited
non-zero with no output (e.g. `grep -v` with no matches), breaking
--omit-empty-rows.
Now mani drops the synthetic 'exit status N' line for *exec.ExitError
only. Other error types (I/O failures, plumbing errors, etc.) still
surface. ignore_errors semantics are unchanged: it still controls
whether subsequent commands in a multi-command task run after one
fails on a given project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when a task command exited non-zero, mani appended Go's stdlib *exec.ExitError string ('exit status N') to the output cell (table mode) or to stderr (stream mode). This is internal Go representation leaking through — the command's own stderr is already captured separately, so the suffix added no information when failures were real, and polluted the cell when commands intentionally exited non-zero with no output (e.g.
grep -vwith no matches), breaking --omit-empty-rows.Now mani drops the synthetic 'exit status N' line for *exec.ExitError only. Other error types (I/O failures, plumbing errors, etc.) still surface. ignore_errors semantics are unchanged: it still controls whether subsequent commands in a multi-command task run after one fails on a given project.