Make font bytes optional - #30
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ft-clarify #30 +/- ##
=============================================
Coverage ? 88.63%
=============================================
Files ? 350
Lines ? 55022
Branches ? 3851
=============================================
Hits ? 48770
Misses ? 4831
Partials ? 1421
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
akx
approved these changes
Sep 14, 2026
akx
left a comment
akx
left a comment
Owner
There was a problem hiding this comment.
I'm a little concerned about swapping arguments around, but in this case I think the error (layout engine and bytes swapped around), if anyone had been poking around these privates in userland code, will be pretty glaring and obvious.
akx
pushed a commit
that referenced
this pull request
Sep 15, 2026
* Make font bytes optional * Remove keyword support from core.getfont Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
akx
pushed a commit
that referenced
this pull request
Sep 17, 2026
* Make font bytes optional * Remove keyword support from core.getfont Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion for python-pillow#9908