Skip to content

Use FT_CONFIG_OPTION_USE_HARFBUZZ - #21

Merged
akx merged 1 commit into
akx:harfingfrom
radarhere:harfing
Sep 14, 2026
Merged

akx merged 1 commit into
akx:harfingfrom
radarhere:harfing

Conversation

@radarhere

Copy link
Copy Markdown

Is this a viable simplification for python-pillow#9913?

@akx

akx commented Sep 1, 2026

Copy link
Copy Markdown
Owner

AIUI, FreeType defaults to loading HarfBuzz dynamically unless it's forced as a dependency and found at build time. (And as described in the original issue, that dynamic linkage won't work due to auditwheel's renames.)

But I'll take a look at the libraries that get built here...

@akx akx self-assigned this Sep 1, 2026
@akx

akx commented Sep 4, 2026

Copy link
Copy Markdown
Owner

... I have to keep re-running the macOS workflow because test wheel is flaking on the leak test (fixed in python-pillow#9945) and it's not uploading the artifact before tests work...

@radarhere

Copy link
Copy Markdown
Author

I'm willing to merge the skipping of PyPy leak tests, but less keen on reducing the size for test_empty_image. See what you think of python-pillow#9957

@akx

akx commented Sep 4, 2026

Copy link
Copy Markdown
Owner

but less keen on reducing the size for test_empty_image.

AISI, the idea of the test is to check that these if statements have teeth?

https://github.com/python-pillow/Pillow/blob/3dfc89ea2fd9143e4a3f405da435b9357c4ffcfb/src/libImaging/Fill.c#L26-L29

... and it does so by assuming that image initialization doesn't take over an arbitrary duration. I have another idea, let me open up a PR...

See what you think of python-pillow#9957

Replied there. I don't think it has the intended effect.

@radarhere

Copy link
Copy Markdown
Author

python-pillow#9933 is merged. That should help you evaluate this.

@akx akx left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally managed to take a look at the wheel.

Yeah, looks like the correct symbols are there in this build too.

$ nm -u PIL/.dylibs/libfreetype.6.dylib | grep _hb_ot_
_hb_ot_layout_collect_lookups
_hb_ot_layout_lookup_collect_glyphs
_hb_ot_layout_lookup_would_substitute
_hb_ot_tags_from_script_and_language

@akx
akx merged commit 4e89b3b into akx:harfing Sep 14, 2026
86 of 90 checks passed
@radarhere
radarhere deleted the harfing branch September 15, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants