Skip to content

Integrate post-1.0 hardening and opt-in high-rate presentation - #1

Open
akratch wants to merge 1 commit into
mainfrom
post-1.0-integration
Open

Integrate post-1.0 hardening and opt-in high-rate presentation#1
akratch wants to merge 1 commit into
mainfrom
post-1.0-integration

Conversation

@akratch

@akratch akratch commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Preserve the authored simulation cadence and original presentation policy as the defaults.
  • Add explicitly selectable display, numeric, and uncapped presentation rates with interpolation, bounded GPU queues, and lifecycle coverage.
  • Integrate real-ROM oracle replay diagnostics, fail-closed magic-code validation, macOS signing/notarization repairs, and native audio qualification.
  • Put the native/source and generated web repositories one click from each other in both READMEs.

The integration commit is parented directly to public main and contains only the reviewed public tree. No ROM or ROM-derived game assets are included.

Validation

  • Release CTest: 42/42 passed.
  • Public-surface policy: passed for the exact tree and new commit range.
  • Clean-room and full-history ROM guard: passed.
  • Release-readiness guard and shipped web artifact scan: passed.
  • Self-contained macOS app/DMG: launcher smoke passed; default/original and opt-in 240 Hz packaged runs passed; mounted app integrity and asset-free scan passed.

Release publication remains a separate manual decision.

Keep the authored simulation cadence and original presentation policy as defaults while adding explicitly selectable display, numeric, and uncapped presentation modes.\n\nAlso integrate presentation interpolation and lifecycle coverage, real-ROM oracle replay diagnostics, fail-closed magic-code validation, macOS signing/notarization repairs, native audio queue qualification, and clearer native/web repository navigation.\n\nNo ROM or ROM-derived game assets are included.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d7d3bb6ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +190 to +192
gh release view "$RELEASE_TAG" >/dev/null
gh release upload "$RELEASE_TAG" \
"$DMG_PATH" "${DMG_PATH}.sha256" "${DMG_PATH}.provenance.json"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Bind the uploaded release to the checked-out commit

When this workflow is dispatched from a ref other than the commit referenced by RELEASE_TAG, the provenance check only proves that the artifact was built from github.sha; it never verifies that the release tag points to that SHA. The gh release upload manual specifies gh release upload <tag> <files>..., so the subsequent command will attach the differently sourced, signed artifact to whatever existing tag the operator entered. Resolve and dereference the tag and require it to equal SOURCE_COMMIT before uploading, otherwise a release can distribute a binary built from the wrong commit.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant