refactor(sql): convert SqlQuery and SqlExecute to idiomatic FFI#87
Merged
refactor(sql): convert SqlQuery and SqlExecute to idiomatic FFI#87
Conversation
- SqlQuery: (conn any, sql string, values []any) ([]any, error) - SqlExecute: (conn any, sql string, values []any) error - Remove runtime/checker imports from sql.go - Remove sqlArgValue helper (no longer needed) - Refactor executeQuery to return ([]any, error) Raw FFI count: 12 → 10 Both functions now use []any for values parameter, which is supported by the generator after recent changes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts
SqlQueryandSqlExecutefrom raw FFI to idiomatic FFI, leveraging the recently added[]anygenerator support.Changes
Before (raw FFI):
After (idiomatic FFI):
Generated Wrappers
Cleanup
runtimeandcheckerimports fromsql.gosqlArgValuehelper function (no longer needed)executeQueryto return([]any, error)Stats
Testing