perf: store components in archetype-indexed slices instead of maps#32
Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
ComponentsStorage kept its component columns in a map[archetypeId][]T, hashing on every storage access. archetypeId is dense, so the columns are now held in a [][]T indexed directly by archetypeId, removing the hash from every add, remove, copy and query read. Query columns are fetched through a bounds-safe getColumn: a query with an optional component matches archetypes that don't contain it, whose id can be beyond that component's column slice — a raw index would panic (a map returned nil). getColumn is kept out of line (//go:noinline) so it does not perturb the hot loops; this also makes iteration slightly faster than the previous map. The query Foreach loops gain a fast path for the common case where all columns are present, hoisting the per-entity nil checks (needed only for optional components) out of the loop.
43f7a94 to
7b56d83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComponentsStorage kept its component columns in a map[archetypeId][]T, hashing on every storage access. archetypeId is dense, so the columns are now held in a [][]T indexed directly by archetypeId, removing the hash from every add, remove, copy and query read.
Query columns are fetched through a bounds-safe getColumn: a query with an optional component matches archetypes that don't contain it, whose id can be beyond that component's column slice — a raw index would panic (a map returned nil). getColumn is kept out of line (//go:noinline) so it does not perturb the hot loops; this also makes iteration slightly faster than the previous map.
The query Foreach loops gain a fast path for the common case where all columns are present, hoisting the per-entity nil checks (needed only for optional components) out of the loop.