perf: cache archetype transitions to avoid the per-operation linear scan#31
Merged
Conversation
Each archetype now caches its add/remove edges to neighbour archetypes. A single-component transition (Add/RemoveComponent, Add/RemoveTag) resolves the destination archetype via an O(1) edge lookup instead of rebuilding an id slice and scanning every archetype; the scan remains as a fallback to populate the edge and for multi-component operations. This also fixes a latent corruption: removeComponent and RemoveTag held a *archetype taken before getArchetypeForComponentsIds, which can create a new archetype and reallocate world.archetypes (past the 1024 preallocated cap), leaving the pointer stale. The destination is now resolved first and both archetypes are re-fetched by index.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each archetype now caches its add/remove edges to neighbour archetypes. A single-component transition (Add/RemoveComponent, Add/RemoveTag) resolves the destination archetype via an O(1) edge lookup instead of rebuilding an id slice and scanning every archetype; the scan remains as a fallback to populate the edge and for multi-component operations.
This also fixes a latent corruption: removeComponent and RemoveTag held a *archetype taken before getArchetypeForComponentsIds, which can create a new archetype and reallocate world.archetypes (past the 1024 preallocated cap), leaving the pointer stale. The destination is now resolved first and both archetypes are re-fetched by index.