Skip to content

feat(engine): embed cluster node id into worker-scoped ids #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfallows merged 4 commits into from
Aug 24, 2026
+1,165 −289
Merged

feat(engine): embed cluster node id into worker-scoped ids #2421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
282e19b
feat(engine): embed cluster node id into worker-scoped ids
claude Aug 23, 2026
81d7d60
feat(command-dump): decode node id from trace id in the wireshark dis…
claude Aug 23, 2026
d769be1
fix(command-dump): update dump IT golden fixtures for trace id subtree
claude Aug 23, 2026
55ffaf7
Merge remote-tracking branch 'origin/develop' into claude/cluster-wid…
claude Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...dump/src/main/resources/io/aklivity/zilla/runtime/command/dump/internal/airline/zilla.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ add_field("acknowledge", ProtoField.int64("zilla.acknowledge", "Acknowledge", ba
add_field("maximum", ProtoField.int32("zilla.maximum", "Maximum", base.DEC))
add_field("timestamp", ProtoField.uint64("zilla.timestamp", "Timestamp", base.HEX))
add_field("trace_id", ProtoField.uint64("zilla.trace_id", "Trace ID", base.HEX))
add_field("trace_id_node", ProtoField.uint8("zilla.trace_id.node", "Node", base.DEC))
add_field("trace_id_worker", ProtoField.uint8("zilla.trace_id.worker", "Worker", base.DEC))
add_field("authorization", ProtoField.uint64("zilla.authorization", "Authorization", base.HEX))

-- begin frame
Expand Down Expand Up @@ -575,7 +577,10 @@ function zilla_protocol.dissector(buffer, pinfo, tree)
subtree:add_le(fields.acknowledge, slice_acknowledge)
subtree:add_le(fields.maximum, slice_maximum)
subtree:add_le(fields.timestamp, slice_timestamp)
subtree:add_le(fields.trace_id, slice_trace_id)
local trace_id_subtree = subtree:add(zilla_protocol, slice_trace_id, "Trace ID")
trace_id_subtree:add_le(fields.trace_id, slice_trace_id)
trace_id_subtree:add_le(fields.trace_id_node, buffer(frame_offset + 62, 1))
trace_id_subtree:add_le(fields.trace_id_worker, buffer(frame_offset + 63, 1))
subtree:add_le(fields.authorization, slice_authorization)

pinfo.cols.protocol = zilla_protocol.name
Expand Down
120 changes: 96 additions & 24 deletions .../zilla/runtime/command/dump/internal/AmqpLinkNetworkIT_shouldExchangeAttachAsReceiver.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ Zilla Frame
Acknowledge: 0
Maximum: 0
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000001
Trace ID
Trace ID: 0x8000000000000001
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Affinity: 0x0000000000000000
Redirected ID: 0x0000000000000000
Expand Down Expand Up @@ -53,7 +56,10 @@ Zilla Frame
Acknowledge: 0
Maximum: 0
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000002
Trace ID
Trace ID: 0x8000000000000002
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Affinity: 0x0000000000000000
Redirected ID: 0x0000000000000000
Expand Down Expand Up @@ -83,7 +89,10 @@ Zilla Frame
Acknowledge: 0
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000003
Trace ID
Trace ID: 0x8000000000000003
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Padding: 0
Expand Down Expand Up @@ -117,7 +126,10 @@ Zilla Frame
Acknowledge: 0
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000004
Trace ID
Trace ID: 0x8000000000000004
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Padding: 0
Expand Down Expand Up @@ -151,7 +163,10 @@ Zilla Frame
Acknowledge: 0
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000005
Trace ID
Trace ID: 0x8000000000000005
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Flags: 0x03
.... ...1 = FIN: Set (1)
Expand Down Expand Up @@ -192,7 +207,10 @@ Zilla Frame
Acknowledge: 8
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000006
Trace ID
Trace ID: 0x8000000000000006
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Padding: 0
Expand Down Expand Up @@ -226,7 +244,10 @@ Zilla Frame
Acknowledge: 0
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000007
Trace ID
Trace ID: 0x8000000000000007
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Flags: 0x03
.... ...1 = FIN: Set (1)
Expand Down Expand Up @@ -267,7 +288,10 @@ Zilla Frame
Acknowledge: 8
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000008
Trace ID
Trace ID: 0x8000000000000008
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Padding: 0
Expand Down Expand Up @@ -301,7 +325,10 @@ Zilla Frame
Acknowledge: 8
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000009
Trace ID
Trace ID: 0x8000000000000009
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Flags: 0x03
.... ...1 = FIN: Set (1)
Expand Down Expand Up @@ -342,7 +369,10 @@ Zilla Frame
Acknowledge: 30
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x800000000000000a
Trace ID
Trace ID: 0x800000000000000a
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Padding: 0
Expand Down Expand Up @@ -376,7 +406,10 @@ Zilla Frame
Acknowledge: 8
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x800000000000000b
Trace ID
Trace ID: 0x800000000000000b
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Flags: 0x03
.... ...1 = FIN: Set (1)
Expand Down Expand Up @@ -417,7 +450,10 @@ Zilla Frame
Acknowledge: 30
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x800000000000000c
Trace ID
Trace ID: 0x800000000000000c
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Padding: 0
Expand Down Expand Up @@ -451,7 +487,10 @@ Zilla Frame
Acknowledge: 30
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x800000000000000d
Trace ID
Trace ID: 0x800000000000000d
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Flags: 0x03
.... ...1 = FIN: Set (1)
Expand Down Expand Up @@ -492,7 +531,10 @@ Zilla Frame
Acknowledge: 57
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x800000000000000e
Trace ID
Trace ID: 0x800000000000000e
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Padding: 0
Expand Down Expand Up @@ -526,7 +568,10 @@ Zilla Frame
Acknowledge: 30
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x800000000000000f
Trace ID
Trace ID: 0x800000000000000f
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Flags: 0x03
.... ...1 = FIN: Set (1)
Expand Down Expand Up @@ -567,7 +612,10 @@ Zilla Frame
Acknowledge: 59
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000010
Trace ID
Trace ID: 0x8000000000000010
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Padding: 0
Expand Down Expand Up @@ -601,7 +649,10 @@ Zilla Frame
Acknowledge: 57
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000011
Trace ID
Trace ID: 0x8000000000000011
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Flags: 0x03
.... ...1 = FIN: Set (1)
Expand Down Expand Up @@ -642,7 +693,10 @@ Zilla Frame
Acknowledge: 99
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000012
Trace ID
Trace ID: 0x8000000000000012
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Padding: 0
Expand Down Expand Up @@ -676,7 +730,10 @@ Zilla Frame
Acknowledge: 59
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000013
Trace ID
Trace ID: 0x8000000000000013
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Flags: 0x03
.... ...1 = FIN: Set (1)
Expand Down Expand Up @@ -717,7 +774,10 @@ Zilla Frame
Acknowledge: 108
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000014
Trace ID
Trace ID: 0x8000000000000014
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Padding: 0
Expand Down Expand Up @@ -751,7 +811,10 @@ Zilla Frame
Acknowledge: 99
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000015
Trace ID
Trace ID: 0x8000000000000015
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Flags: 0x03
.... ...1 = FIN: Set (1)
Expand Down Expand Up @@ -792,7 +855,10 @@ Zilla Frame
Acknowledge: 99
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000016
Trace ID
Trace ID: 0x8000000000000016
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Reserved: 0
Expand Down Expand Up @@ -822,7 +888,10 @@ Zilla Frame
Acknowledge: 127
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000017
Trace ID
Trace ID: 0x8000000000000017
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Padding: 0
Expand Down Expand Up @@ -856,7 +925,10 @@ Zilla Frame
Acknowledge: 108
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000018
Trace ID
Trace ID: 0x8000000000000018
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Reserved: 0
Expand Down
30 changes: 24 additions & 6 deletions ...lla/runtime/command/dump/internal/AmqpStreamApplicationIT_shouldConnectAsReceiverOnly.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ Zilla Frame
Acknowledge: 0
Maximum: 0
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000001
Trace ID
Trace ID: 0x8000000000000001
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Affinity: 0x0000000000000000
Redirected ID: 0x0000000000000000
Expand Down Expand Up @@ -62,7 +65,10 @@ Zilla Frame
Acknowledge: 0
Maximum: 0
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000002
Trace ID
Trace ID: 0x8000000000000002
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Affinity: 0x0000000000000000
Redirected ID: 0x0000000000000000
Expand Down Expand Up @@ -101,7 +107,10 @@ Zilla Frame
Acknowledge: 0
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000003
Trace ID
Trace ID: 0x8000000000000003
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Padding: 0
Expand Down Expand Up @@ -135,7 +144,10 @@ Zilla Frame
Acknowledge: 0
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000004
Trace ID
Trace ID: 0x8000000000000004
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Padding: 0
Expand Down Expand Up @@ -169,7 +181,10 @@ Zilla Frame
Acknowledge: 0
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000005
Trace ID
Trace ID: 0x8000000000000005
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Reserved: 0
Expand Down Expand Up @@ -199,7 +214,10 @@ Zilla Frame
Acknowledge: 0
Maximum: 8192
Timestamp: 0x0000000000000000
Trace ID: 0x8000000000000006
Trace ID
Trace ID: 0x8000000000000006
Node: 0
Worker: 128
Authorization: 0x0000000000000000
Budget ID: 0x0000000000000000
Reserved: 0
Expand Down
Loading
Loading