compose: kill the sendmail process on timeout#138
Open
laarmen wants to merge 1 commit intoakissinger:masterfrom
Open
compose: kill the sendmail process on timeout#138laarmen wants to merge 1 commit intoakissinger:masterfrom
laarmen wants to merge 1 commit intoakissinger:masterfrom
Conversation
When you write an email and your sendmail process times out, the thread finishes, but the underlying process is still kicking around. This results in duplicate emails being sent, as the user (randomly, me) will try again. In my case, it happens because I use `gmi` for both syncing and sending email, and the send subcommand actually blocks if a sync is in progress, and sometimes those can be pretty long if you have a lot of tag changes (Google is pretty swift in rate-limiting). I also patched that tool to fail rather than block, but I figure that Dodo should also do the right thing here. Further work would be to also think about that process when the main one exits, but that's out of scope for this patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you write an email and your sendmail process times out, the thread finishes, but the underlying process is still kicking around. This results in duplicate emails being sent, as the user (randomly, me) will try again.
In my case, it happens because I use
gmifor both syncing and sending email, and the send subcommand actually blocks if a sync is in progress, and sometimes those can be pretty long if you have a lot of tag changes (Google is pretty swift in rate-limiting). I also patched that tool to fail rather than block, but I figure that Dodo should also do the right thing here.Further work would be to also think about that process when the main one exits, but that's out of scope for this patch.