app: call raise_() before activateWindow() so dodo comes to front on macOS#136
Open
klement wants to merge 1 commit intoakissinger:masterfrom
Open
app: call raise_() before activateWindow() so dodo comes to front on macOS#136klement wants to merge 1 commit intoakissinger:masterfrom
klement wants to merge 1 commit intoakissinger:masterfrom
Conversation
…macOS Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On macOS, when returning from an external editor (e.g. after composing a message),
activateWindow()alone does not reliably bring the dodo window back to the foreground. Addingraise_()beforeactivateWindow()ensures the window comes to the front and receives keyboard focus when the editor process finishes.Test plan