fix: use custom user-agent and add Accept headers when fetching rss#322
Open
rudism wants to merge 1 commit into
Open
fix: use custom user-agent and add Accept headers when fetching rss#322rudism wants to merge 1 commit into
rudism wants to merge 1 commit into
Conversation
closes akhilrex#303, closes akhilrex#225, closes akhilrex#182, closes akhilrex#313, closes akhilrex#312
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the configured custom user agent was only used when downloading files and not the actual podcast feed RSS, this commit fixes that (user agent is applied in both cases). Also added an
Accept: */*header, since a lot of servers give 403/forbidden or other opaque errors when its missing.This fixes several feeds for me and likely addresses these issues (and maybe more):
closes #303, closes #225, closes #182, closes #313, closes #312
If anyone wishes to use this patch prior to being merged (as it seems development has slowed or stalled here), I have published a podgrab image with this patch applied that you can use as a drop-in replacement for the official docker image at
ghcr.io/rudism/podgrab:latest