Skip to content

[codex] fix mobile panel theme inheritance #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kachofugetsu09 merged 1 commit into from
Aug 22, 2026
Merged

[codex] fix mobile panel theme inheritance #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 9 additions & 21 deletions mobile_panel.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,16 @@
.proactive-feedback {
--feedback-follow: #39b9b1;
--feedback-follow-ink: #082f2c;
--feedback-quote: #bd8add;
--feedback-quote-ink: #321640;
--feedback-confidence: #7aa7ef;
--feedback-confidence-ink: #102d58;
--feedback-uncertain-ink: #6d4d00;
--feedback-follow: var(--ak-sys-color-success-container);
--feedback-follow-ink: var(--ak-sys-color-on-success-container);
--feedback-quote: var(--ak-sys-color-trace-container);
--feedback-quote-ink: var(--ak-sys-color-on-trace-container);
--feedback-confidence: var(--ak-color-action-container);
--feedback-confidence-ink: var(--ak-color-on-action-container);
--feedback-uncertain-ink: var(--ak-sys-color-warning);
color: var(--ak-color-text-primary);
font-family: Roboto, "Noto Sans SC", system-ui, sans-serif;
font-synthesis: none;
}

@supports (color: oklch(0 0 0)) {
.proactive-feedback {
--feedback-follow: oklch(0.72 0.125 184);
--feedback-follow-ink: oklch(0.24 0.045 184);
--feedback-quote: oklch(0.72 0.13 310);
--feedback-quote-ink: oklch(0.27 0.065 310);
--feedback-confidence: oklch(0.72 0.12 255);
--feedback-confidence-ink: oklch(0.27 0.065 255);
--feedback-uncertain-ink: oklch(0.43 0.09 78);
}
}

.proactive-feedback-loading {
padding: 28px 4px;
color: var(--ak-color-text-secondary);
Expand All @@ -43,7 +31,7 @@

.proactive-feedback-rate {
display: flex;
min-height: 156px;
min-height: 132px;
flex-direction: column;
justify-content: flex-end;
border-radius: var(--m-shape-large-increased, 20px);
Expand All @@ -53,7 +41,7 @@
}

.proactive-feedback-rate strong {
font-size: 2.75rem;
font-size: 2.25rem;
font-weight: 650;
letter-spacing: -0.045em;
line-height: 0.95;
Expand Down
11 changes: 11 additions & 0 deletions tests/test_mobile_panel.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { readFile } from "node:fs/promises";
import test from "node:test";

const source = await readFile(new URL("../mobile_panel.js", import.meta.url), "utf8");
const styles = await readFile(new URL("../mobile_panel.css", import.meta.url), "utf8");
const panel = await import(`data:text/javascript;base64,${Buffer.from(source).toString("base64")}`);

class FakeElement {
Expand Down Expand Up @@ -118,6 +119,16 @@ test("mobile panel keeps content in plugin-owned module", () => {
assert.doesNotMatch(source, /window\.AkashicDashboard/);
});

test("mobile panel inherits semantic colors from the shared Material theme", () => {
assert.match(styles, /var\(--ak-sys-color-success-container\)/);
assert.match(styles, /var\(--ak-sys-color-on-success-container\)/);
assert.match(styles, /var\(--ak-sys-color-trace-container\)/);
assert.match(styles, /var\(--ak-sys-color-on-trace-container\)/);
assert.match(styles, /var\(--ak-color-action-container\)/);
assert.doesNotMatch(styles, /#[0-9a-f]{3,8}\b/i);
assert.doesNotMatch(styles, /oklch\([^,)]*\)/);
});

test("feedback row expands its relation and keeps aria state in sync", () => {
globalThis.document = {
createElement(tagName) { return new FakeElement(tagName); },
Expand Down
Loading