fix(runtime): keep candidate feedback topology stable - #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
结论
让 candidate 与 formal Root 声明同一个 committed-turn listener，同时 candidate 继续不启动持久 worker、不读取正式 Session、也不写正式 plugin-data。
根因
候选行为验证成功后，Core 会用正式 runtime 重建同一个 generation 并校验 snapshot identity。此前 listener 仅在 formal Root 注册，使任何插件候选晋升都会被正确地判为拓扑漂移。
验证
python -m pytest -q tests: 30 passednode --test tests/test_mobile_panel.mjs: 5 passedpyright --level error ...: 0 errorspublish_prepared，并断言 candidate/formal topology identity 相同、candidate 事件不产生数据库写入。