test: complete OpenAI provider error-normalization coverage - #43
Merged
Conversation
The provider test suite covered success, defaults, timeout, rate-limit (with retry telemetry), and unknown errors — but the two real-world failure branches were unpinned: - APIConnectionError -> 503 'AI provider is temporarily unavailable' with providerCode connection_error - generic APIError (e.g. 400) -> 502 'AI provider request failed' with the provider's request id and code surfaced on the AIProviderError No production code changed.
✅ Deploy Preview for teamsynch-ai canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OpenAI provider test suite covered success, defaults, timeout, rate-limit (with retry telemetry), and unknown errors — but the two real-world failure branches were unpinned: connection failures (provider unreachable) and generic API errors (e.g. a 400 from the LLM API). These determine whether operations sees an honest 503 vs 502 and whether the provider's request id / error code surfaces in the AI observability stack.
Solution
Two new deterministic tests in
openai.provider.test.ts(mocked SDK, no network):APIConnectionError→ 503 "AI provider is temporarily unavailable" withproviderCode: 'connection_error'.APIError(400) → 502 "AI provider request failed" with the provider'srequestIDandcodesurfaced on theAIProviderError(so they flow into the failure structured log asproviderRequestIdand the error-code metric).Validation results
npm run typecheck: cleannpm run build: cleanRisk
LOW. Tests only — no production code touched.
Rollback
Revert the PR (delete the added tests). No production impact either way.
Production behavior
Not changed. Provider error handling is untouched. Only coverage was added.