test: pin the AI usage DTO validation contract - #39
Merged
Conversation
GetAIUsageSchema is the zod contract the ai-usage analytics route enforces (only the bounded days param), but it had no direct test. New deterministic tests: - accepts empty params (defaults), valid days 1/7/30/90, numeric-string coercion, rejects days > 90 or < 1, non-integer days (incl. NaN), unknown query fields, unknown body fields, unknown params - documents AI_USAGE_DEFAULT_DAYS=30 / AI_USAGE_MAX_DAYS=90 No production code changed.
✅ Deploy Preview for teamsynch-ai canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GetAIUsageSchemais the zod contract the AI usage analytics route (GET /api/v1/analytics/ai-usage) enforces — it accepts only the boundeddaysquery parameter (1–90, integer) and rejects everything else. It had no direct unit coverage, so the contract was unpinned.Solution
A new deterministic test suite (
ai-usage.dto.test.ts, DB-free):'30'→ 30)NaN)AI_USAGE_DEFAULT_DAYS = 30andAI_USAGE_MAX_DAYS = 90Validation results
npm run typecheck: cleannpm run build: cleanRisk
LOW. Tests only — no production code touched.
Rollback
Revert the PR (delete the test file). No production impact either way.
Production behavior
Not changed. The DTO, route, and analytics behavior are untouched. Only coverage was added.